Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not throw when controller type is not found, return nullptr instead #387

Merged
merged 2 commits into from
Apr 21, 2021
Merged

Do not throw when controller type is not found, return nullptr instead #387

merged 2 commits into from
Apr 21, 2021

Conversation

AugusteBourgois
Copy link
Contributor

solves #384

bmagyar
bmagyar approved these changes Apr 21, 2021
View reviewed changes
Copy link
Member

@bmagyar bmagyar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this, looks good to me!
@destogl ?

@bmagyar bmagyar requested a review from destogl April 21, 2021 07:00
@destogl
Copy link
Member

destogl commented Apr 21, 2021

Looks great. Will this brake some tests in ros2_controllers repo? E.g., loading of the controllers?

@bmagyar
Copy link
Member

bmagyar commented Apr 21, 2021

Let's see, we can touch up in case it breaks the load tests

@bmagyar bmagyar merged commit 29ea032 into ros-controls:master Apr 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@destogl destogl destogl approved these changes

@bmagyar bmagyar bmagyar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@AugusteBourgois @destogl @bmagyar