Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

introduce --stopped for spawner #402

Merged
merged 1 commit into from
Apr 29, 2021
Merged

introduce --stopped for spawner #402

merged 1 commit into from
Apr 29, 2021

Conversation

Karsten1987
Copy link
Contributor

as per title, the spawner.py script gets an additional --stopped argument to only load & configure the controller, however not starting it.

Signed-off-by: Karsten Knese <Karsten1987@users.noreply.github.com>
Copy link
Member

@destogl destogl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, you are clearing my todo list :)

@destogl
Copy link
Member

destogl commented Apr 29, 2021

One more idea: to be closer to the ROS1 wording, should be also have am option "--load-only" for this functionality?

@Karsten1987
Copy link
Contributor Author

I was thinking to replicate what we had in ros2 control load in which we add a --set-state command. But I actually believe the ROS1 wording is --stopped.
From here: http://wiki.ros.org/controller_manager#spawner

$ rosrun controller_manager spawner [--stopped] <name1> <name2> ...

@Karsten1987 Karsten1987 merged commit 3744fc7 into master Apr 29, 2021
@Karsten1987 Karsten1987 deleted the spawn_stopped branch April 29, 2021 06:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants