Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump wait_for_service timeout to 10 seconds #403

Merged
merged 1 commit into from
Apr 29, 2021
Merged

Conversation

Karsten1987
Copy link
Contributor

The controller manager might need a few seconds to boot all their hardware resources before the actual spin is triggered and its services are available.
The spawner.py script might be called simultaneously within the same launch file and should thus be able to wait for a bit longer in order for the CM services to be available.

The controller manager might need a few seconds to boot all their hardware resources before the actual `spin` is triggered and its services are available.
The spawner.py script might be called simultaneously within the same launch file and should thus be able to wait for a bit longer in order for the CM services to be available.
Copy link
Member

@destogl destogl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also had this issue, but never managed to finalize PR for it. What do you think about setting timeout using a parameter?

@Karsten1987
Copy link
Contributor Author

Yeah, definitely the right thing to do. I'll create a follow-up issue for this.

@Karsten1987 Karsten1987 merged commit e782aa7 into master Apr 29, 2021
@Karsten1987 Karsten1987 deleted the Karsten1987-patch-1 branch April 29, 2021 06:11
@Karsten1987
Copy link
Contributor Author

#405

destogl pushed a commit to StoglRobotics-forks/ros2_control that referenced this pull request Aug 11, 2022
This use of `auto` is causing a static assert on RHEL. Explicitly
specifying the type seems to resolve the failure and allow the test to
be compiled.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants