Make controller manager update rate optional #404
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
destogl
reviewed
Apr 29, 2021
bmagyar
reviewed
Apr 30, 2021
I believe it's still good practice to declare a desired update rate, but we shouldn't necessarily require it and actually default it to 100 if not declared. The current logic was flawed in a way that it would always raise the exception if the parameter wasn't set.
bmagyar
force-pushed
the
Karsten1987-patch-2
branch
from
56c3c17
to
7a9ed60
Compare
|
@Karsten1987 I applied the suggested changes + rebased the branch. Feel free to merge if you like it this way. |
bmagyar
approved these changes
Apr 30, 2021
destogl
approved these changes
Apr 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe it's still good practice to declare a desired update rate, but we shouldn't necessarily require it and actually default it to 100 if not declared.
The current logic was flawed in a way that it would always raise the exception if the parameter wasn't set.