Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Possible error in JointCommandHandle::set_cmd(double cmd) #42

Closed
Mariunil opened this issue Feb 3, 2020 · 2 comments · Fixed by #44
Closed

Possible error in JointCommandHandle::set_cmd(double cmd) #42

Mariunil opened this issue Feb 3, 2020 · 2 comments · Fixed by #44

Comments

@Mariunil
Copy link

Mariunil commented Feb 3, 2020

ros2_control/hardware_interface/src/joint_command_handle.cpp

Line 53 in 719cb6c

THROW_ON_NULLPTR(cmd)

I believe THROW_ON_NULLPTR should check cmd_ and not cmd.
@brightenlee
Copy link

I'm also using ros2 controller after commenting out this line.

@Karsten1987 Karsten1987 mentioned this issue Feb 3, 2020
Merged
@Karsten1987
Copy link
Contributor

This issue was addressed in 7b9adc4

I looks like the current master is not on pair with the dashing branch.
I'll address that ASAP.

@Karsten1987 Karsten1987 mentioned this issue Feb 4, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix master build ros-controls/ros2_control
3 participants
@Karsten1987 @brightenlee @Mariunil