Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use correct names after changing arguments #425

Merged
merged 1 commit into from
May 31, 2021
Merged

Use correct names after changing arguments #425

merged 1 commit into from
May 31, 2021

Conversation

destogl
Copy link
Member

@destogl destogl commented May 28, 2021

In #412 we forgot to update the argument after changing flags.

@destogl
Use correct names after changing arguments
67ea576 
In #412 we forgot to update the argument after changing flags.
@destogl destogl self-assigned this May 28, 2021
@destogl destogl added the bug label May 28, 2021
bmagyar
bmagyar approved these changes May 31, 2021
View reviewed changes
Copy link
Member

@bmagyar bmagyar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we only had some unit tests on these cli verbs...

@bmagyar bmagyar merged commit d59df42 into master May 31, 2021
@destogl destogl deleted the destogl-patch-1 branch May 31, 2021 08:49
livanov93 pushed a commit to livanov93/ros2_control that referenced this pull request Mar 22, 2023
@ShotaAk
Add an initialization of the gripper action command for safe startup. (…
fe306da 
…ros-controls#425)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bmagyar bmagyar bmagyar approved these changes

@Karsten1987 Karsten1987 Awaiting requested review from Karsten1987

@jordan-palacios jordan-palacios Awaiting requested review from jordan-palacios

Assignees

@destogl destogl

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@destogl @bmagyar