Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add clang-format file to repo #45

Closed
bmagyar opened this issue Feb 4, 2020 · 6 comments
Closed

Add clang-format file to repo #45

bmagyar opened this issue Feb 4, 2020 · 6 comments
Assignees

Comments

@bmagyar
Copy link
Member

bmagyar commented Feb 4, 2020

No description provided.

@JafarAbdi
Copy link
Contributor

@bmagyar Is there any style that you would prefer (for example MoveIt clang-format .? I could create a PR to fix this issue

@bmagyar
Copy link
Member Author

bmagyar commented Feb 21, 2020

I think we'd be quite happy with most of that. One thing though that I remember seeing in moveit a lot is

if (a)
  b();

while I'd prefer personally

if (a)
{
  b();
}

for more consistency. Can this be added?

@JafarAbdi
Copy link
Contributor

Seems like clang-format doesn't support this, but we could use clang-tidy to do so see

@bmagyar
Copy link
Member Author

bmagyar commented Feb 26, 2020

Could you please open a PR with this?

@Karsten1987
Copy link
Contributor

for an initial start for the clang format, does this help? ament/ament_lint#226

This at least sorts the #includes correctly.

@bmagyar
Copy link
Member Author

bmagyar commented Feb 15, 2021

opted for uncrustify to follow the crowd

@bmagyar bmagyar closed this as completed Feb 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants