Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add controller_manager_msgs dependency to test_hardware_management_srvs #702

Merged
merged 1 commit into from
Apr 20, 2022
Merged

Add controller_manager_msgs dependency to test_hardware_management_srvs #702

merged 1 commit into from
Apr 20, 2022

Conversation

rcywongaa
Copy link
Contributor

Fixes issue

/ros2_workspace/src/ros-controls/ros2_control/controller_manager/test/test_hardware_management_srvs.cpp:128:35: error: ‘const value_type’ {aka ‘const struct controller_manager_msgs::msg::HardwareInterface_<std::allocator<void> >’} has no member named ‘is_available’
  128 |           EXPECT_EQ(interfaces[i].is_available, is_available_status[i]);
      |                                   ^~~~~~~~~~~~

erickisos
erickisos approved these changes Apr 18, 2022
View reviewed changes
Copy link
Contributor

@erickisos erickisos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

destogl
destogl approved these changes Apr 19, 2022
View reviewed changes
Copy link
Member

@destogl destogl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good! Thanks!

Needs to be backported to Galactic too.

@bmagyar bmagyar merged commit bb8eab1 into ros-controls:master Apr 20, 2022
mergify bot pushed a commit that referenced this pull request Apr 20, 2022
@rcywongaa
Add controller_manager_msgs dependency to test_hardware_management_sr…
1d97ec1 
…vs (#702)

(cherry picked from commit bb8eab1)

# Conflicts:
#	controller_manager/CMakeLists.txt
@mergify mergify bot mentioned this pull request Apr 20, 2022
Closed
@rcywongaa rcywongaa deleted the Add_controller_manager_msgs_dependency_to_test_hardware_management_srvs branch April 20, 2022 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@destogl destogl destogl approved these changes

@bmagyar bmagyar bmagyar approved these changes

@erickisos erickisos erickisos approved these changes

@a10263790 a10263790 Awaiting requested review from a10263790

@bijoua29 bijoua29 Awaiting requested review from bijoua29

@livanov93 livanov93 Awaiting requested review from livanov93

@Serafadam Serafadam Awaiting requested review from Serafadam

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@rcywongaa @destogl @bmagyar @erickisos