Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Period in CM always 0 #738

Merged
merged 1 commit into from
Jun 27, 2022
Merged

Period in CM always 0 #738

merged 1 commit into from
Jun 27, 2022

Conversation

mcbed
Copy link
Member

@mcbed mcbed commented Jun 24, 2022

Fixed broken period in controllers and hardware returning always 0.

@mcbed mcbed changed the title Period in CM allways 0 Period in CM always 0 Jun 24, 2022
@bmagyar
Copy link
Member

bmagyar commented Jun 27, 2022

you mean it's 0 on the first iteration?

@mcbed
Copy link
Member Author

mcbed commented Jun 27, 2022

It was always 0 as previous_time = current_time before the period is computed.

Copy link
Member

@bmagyar bmagyar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you are right, let's put this quick fix in prior to other reworks

@bmagyar bmagyar merged commit bcfe8b5 into ros-controls:master Jun 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants