Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use rclcpp::Executor instead of rclcpp::executor::Executor(deprecated) #82

Merged
merged 2 commits into from
May 27, 2020

Conversation

bmagyar
Copy link
Member

@bmagyar bmagyar commented May 25, 2020

In response to warning: ‘using Executor = class rclcpp::Executor’ is deprecated: use rclcpp::Executor instead [-Wdeprecated-declarations]

@bmagyar bmagyar requested a review from Karsten1987 May 27, 2020 06:47
@codecov-commenter
Copy link

Codecov Report

Merging #82 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #82   +/-   ##
=======================================
  Coverage   40.72%   40.72%           
=======================================
  Files          24       24           
  Lines         550      550           
  Branches      279      279           
=======================================
  Hits          224      224           
  Misses         98       98           
  Partials      228      228           
Flag Coverage Δ
#unittests 40.72% <100.00%> (ø)
Impacted Files Coverage Δ
.../include/controller_manager/controller_manager.hpp 66.66% <ø> (ø)
controller_manager/src/controller_manager.cpp 56.89% <ø> (ø)
...ontroller_manager/test/test_controller_manager.cpp 26.92% <ø> (ø)
controller_manager/test/test_load_controller.cpp 20.27% <ø> (ø)
...er_parameter_server/test/test_parameter_server.cpp 15.90% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0d56110...ddd9a8d. Read the comment docs.

@bmagyar bmagyar merged commit 259ad77 into ros-controls:master May 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants