Fix QoS deprecation warnings #879
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
anfemosa,
bmagyar,
destogl,
homalozoa,
peterdavidfagan,
progtologist and
VX792
destogl
requested changes
Dec 14, 2022
There was a problem hiding this comment.
Thanks for the contribution!
Would it be possible to create a new variable with QoS setup before initializing all the services, and then reuse it? This should make the change a bit cleaner.
When you're setting up that variable can you copy all full setup (if different from default from the lines 39-48)
|
Thanks for the feedback @destogl. Attempted to address your comments. Let me know if I misunderstood. |
bmagyar
previously approved these changes
Jan 6, 2023
destogl
reviewed
Jan 6, 2023
destogl
reviewed
Jan 6, 2023
destogl
reviewed
Jan 6, 2023
destogl
reviewed
Jan 6, 2023
destogl
reviewed
Jan 6, 2023
pac48
pushed a commit
to pac48/ros2_control
that referenced
this pull request
Jan 26, 2024
* Fix floating point comparison in JTC * Fix format --------- Co-authored-by: Christoph Fröhlich <christophfroehlich@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First PR to fix #862
I'm not familiar with QoS so was a little unsure if
KeepAll()is the correct fix here.