Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add extra joints parameter at joint state broadcaster #179

Merged

Conversation

cesc-folch
Copy link
Contributor

@cesc-folch cesc-folch commented May 4, 2021

Adding a feature that existed in ros1 and was not migrated yet.

@codecov-commenter
Copy link

codecov-commenter commented May 4, 2021

Codecov Report

Merging #179 (2c117ef) into master (189a2f9) will decrease coverage by 0.34%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #179      +/-   ##
==========================================
- Coverage   35.28%   34.93%   -0.35%     
==========================================
  Files          26       26              
  Lines        2256     2290      +34     
  Branches     1462     1493      +31     
==========================================
+ Hits          796      800       +4     
  Misses        132      132              
- Partials     1328     1358      +30     
Flag Coverage Δ
unittests 34.93% <ø> (-0.35%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
..._controllers/src/joint_group_effort_controller.cpp
...ontrollers/src/joint_group_position_controller.cpp
...include/joint_trajectory_controller/trajectory.hpp
...mand_controller/src/forward_command_controller.cpp
...int_trajectory_controller/test/test_trajectory.cpp
...ler/test/test_load_joint_trajectory_controller.cpp
...ollers/test/test_joint_group_effort_controller.cpp
..._state_broadcaster/src/joint_state_broadcaster.cpp
...lers/test/test_joint_group_velocity_controller.cpp
...s/test/test_load_joint_group_effort_controller.cpp
... and 42 more

@cesc-folch cesc-folch marked this pull request as ready for review May 4, 2021 08:07
Copy link
Member

@bmagyar bmagyar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR looks good, good attention to detail with adding tests on first submission! ;)
I'd like to ask one thing however: please add a section on parameters with a very brief explanation as to what is expected when this parameter is specified to joint_state_broadcaster/doc/userdoc.rst

@bmagyar bmagyar merged commit 93ab94b into ros-controls:master May 5, 2021
@jordan-palacios jordan-palacios self-requested a review May 5, 2021 07:44
Copy link
Member

@jordan-palacios jordan-palacios left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants