Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disable griper on OSX #192

Merged
merged 1 commit into from
Jun 9, 2021
Merged

disable griper on OSX #192

merged 1 commit into from
Jun 9, 2021

Conversation

Karsten1987
Copy link
Contributor

experimental/optional is not supported on OSX. I believe the proper fix would be to ifdef the logic around optional, but for now I am simply disabling the compilation on OSX.

Signed-off-by: Karsten Knese <Karsten1987@users.noreply.github.com>
Copy link
Member

@destogl destogl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this really needed to be merged to master? Do we actually habe OSX users? With all the fixes, it sounds like ros2_control is not hardly working on it.

@Karsten1987
Copy link
Contributor Author

I don't see why this PR disturbs any non-OSX users. ROS2 (and ros2_control) works pretty well on OSX so far. I've developed it from day one on OSX ;-)

But it's fine for me if we don't want to merge this. I'll continue working on an internal fork then.

@nkalupahana
Copy link
Contributor

nkalupahana commented Jun 9, 2021

@Karsten1987 What's the status on a fix for this? For now, on my own fork, I'm just switching to C++17, where <optional> is a header on macOS, but that can't be merged in for foxy. All I can think of for a proper fix for this is to use boost::optional, but that's not super ideal. Do you have any ideas? I'm free to take this on.

@bmagyar
Copy link
Member

bmagyar commented Jun 9, 2021

Merging hack, hopefully we can remove it in galactic

@bmagyar bmagyar merged commit 3586ace into master Jun 9, 2021
@Karsten1987 Karsten1987 deleted the disable_gripper_osx branch June 9, 2021 17:39
@Karsten1987
Copy link
Contributor Author

@nkalupahana thanks for the interest. Foxy does not support c++17, we're bound to c++14. I believe that's where the experimental part came in. If we ever decide to branch out for galactic, we can leverage all c++17 features including <optional> (amongst others).
For Foxy though, I don't see a really nice workaround at the moment. Introducing boost is just as brutal and at least for the rest of ros2, we've mainly worked around having it. Disabling the gripper controller for now at least gets me going on OSX with foxy.

@Ace314159 Ace314159 mentioned this pull request Jun 23, 2021
gwalck pushed a commit to StoglRobotics-forks/ros2_controllers that referenced this pull request Jun 7, 2023
* Add joint_limits_interface & missing others to CI
* Add joint_limits_interface to ros2_control metapackage
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants