use rolling mean from rcppmath #211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Where is this actually used? will this available for foxy, galactic, and rolling, or do we have to branch out. |
Karsten1987
force-pushed
the
rcppmath_rolling_mean
branch
from
9c52c09
to
5c9aa6d
Compare
|
you need to branch out, I don't think it's getting backported to any existing distros. And this goes back to the discussion we had in the last WG meeting, that I'd really appreciate having master being the development branch. |
|
Thanks, love to see PRs with a negative balance ;) |
12 tasks
bmagyar
force-pushed
the
rcppmath_rolling_mean
branch
from
5c9aa6d
to
55b83ef
Compare
bmagyar
approved these changes
Aug 31, 2021
bmagyar
force-pushed
the
rcppmath_rolling_mean
branch
from
6e5c1bc
to
7014d1c
Compare
|
waiting a little more on ros2/rcpputils#157 |
Signed-off-by: Karsten Knese <Karsten1987@users.noreply.github.com>
bmagyar
force-pushed
the
rcppmath_rolling_mean
branch
from
7014d1c
to
931af89
Compare
|
Finally merging! |
gwalck
pushed a commit
to StoglRobotics-forks/ros2_controllers
that referenced
this pull request
Jun 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as per title.
With ros2/rcpputils#133 being merged, we really should use rcppmath for the rolling mean.