Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed #255 #256

Merged
merged 3 commits into from
Oct 25, 2021
Merged

Fixed #255 #256

merged 3 commits into from
Oct 25, 2021

Conversation

NoeelMoeskops
Copy link
Contributor

Compiling diff_drive_controller on Fedora (gcc 11.2.1 and glibc 2.33) results in missing definitions in rolling_mean_accumulator.hpp. Adding a simple #include <stdio.h> fixes it though. For more information please see #255.
The Foxy branch could also benefit from this change thought (not sure how to do a pull request for a single commit to two branches).

@bmagyar
Copy link
Member

bmagyar commented Oct 15, 2021

Also, once you made the changes to the branch, please run pre-commit run --all to pass the format stage of the CI.

Don't worry about Foxy or Galactic, I will cherry-pick this change and add to the next release once merged.

@NoeelMoeskops
Copy link
Contributor Author

Also, once you made the changes to the branch, please run pre-commit run --all to pass the format stage of the CI.

Don't worry about Foxy or Galactic, I will cherry-pick this change and add to the next release once merged.

I'm unfamilier with pre-commit. But I ran the command as you said, this is the output:

ros2_controllers git:(master) pre-commit run --all
Check for added large files..............................................Passed
Check python ast.....................................(no files to check)Skipped
Check for case conflicts.................................................Passed
Check docstring is first.............................(no files to check)Skipped
Check for merge conflicts................................................Passed
Check for broken symlinks............................(no files to check)Skipped
Check Xml................................................................Passed
Check Yaml...............................................................Passed
Debug Statements (Python)............................(no files to check)Skipped
Fix End of Files.........................................................Passed
Mixed line ending........................................................Passed
Trim Trailing Whitespace.................................................Passed
fix UTF-8 byte order marker..............................................Passed
pyupgrade............................................(no files to check)Skipped
pep257...............................................(no files to check)Skipped
flake8...............................................(no files to check)Skipped
clang-format.............................................................Failed
- hook id: clang-format
- exit code: 1

Executable `clang-format-10` not found

ament_cppcheck...........................................................Failed
- hook id: ament_cppcheck
- exit code: 1

Executable `ament_cppcheck` not found

ament_cpplint............................................................Failed
- hook id: ament_cpplint
- exit code: 1

Executable `ament_cpplint` not found

ament_lint_cmake.........................................................Failed
- hook id: ament_lint_cmake
- exit code: 1

Executable `ament_lint_cmake` not found

ament_copyright..........................................................Failed
- hook id: ament_copyright
- exit code: 1

Executable `ament_copyright` not found

doc8.....................................................................Passed
rst ``code`` is two backticks............................................Passed
rst directives end with two colons.......................................Passed
rst ``inline code`` next to normal text..................................Passed
codespell................................................................Passed

@destogl
Copy link
Member

destogl commented Oct 19, 2021

I'm unfamilier with pre-commit. But I ran the command as you said, this is the output:

you should source ros workspace to have access to ament_* commands.

@bmagyar bmagyar merged commit c5fe52f into ros-controls:master Oct 25, 2021
gwalck pushed a commit to StoglRobotics-forks/ros2_controllers that referenced this pull request Jun 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants