updated to use node getter functions #329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
a10263790,
arne48,
bijoua29,
bmagyar,
Briancbn,
destogl and
duringhof
jackcenter
force-pushed
the
make_node_private
branch
from
1675589
to
02cc345
Compare
jackcenter
force-pushed
the
make_node_private
branch
from
02cc345
to
de92908
Compare
destogl
reviewed
Apr 19, 2022
gripper_controllers/include/gripper_controllers/gripper_action_controller_impl.hpp
Show resolved
Hide resolved
gripper_controllers/include/gripper_controllers/gripper_action_controller_impl.hpp
Show resolved
Hide resolved
gripper_controllers/include/gripper_controllers/gripper_action_controller_impl.hpp
Show resolved
Hide resolved
bmagyar
approved these changes
Apr 21, 2022
destogl
approved these changes
Apr 21, 2022
destogl
added a commit
to StoglRobotics-forks/ros2_controllers
that referenced
this pull request
Apr 26, 2022
* updated to use node getter functions * updated get_node_const() name Co-authored-by: Denis Štogl <denis@stogl.de> Co-authored-by: Bence Magyar <bence.magyar.robotics@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves ros2_control/issues/679
Depends on: ros2_control/pull/699
Replaced node_ everywhere with get_node() and with get_node_const() inside const functions.