Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add few warning flags to error #961

Merged

Conversation

saikishor
Copy link
Member

Applying similar flags as done in the ros2_control : ros-controls/ros2_control#1181

Copy link

codecov bot commented Jan 3, 2024

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (f14396c) 48.00% compared to head (6000e95) 47.82%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #961      +/-   ##
==========================================
- Coverage   48.00%   47.82%   -0.19%     
==========================================
  Files          41       41              
  Lines        3862     3862              
  Branches     1816     1816              
==========================================
- Hits         1854     1847       -7     
- Misses        745      754       +9     
+ Partials     1263     1261       -2     
Flag Coverage Δ
unittests 47.82% <0.00%> (-0.19%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...include/joint_trajectory_controller/tolerances.hpp 55.00% <0.00%> (ø)
pid_controller/src/pid_controller.cpp 47.74% <0.00%> (ø)

... and 1 file with indirect coverage changes

Copy link
Contributor

@christophfroehlich christophfroehlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM when linters are happy

@saikishor
Copy link
Member Author

@christophfroehlich Thank you. The linters are fixed now.

@bmagyar bmagyar merged commit 2b52f0b into ros-controls:master Jan 4, 2024
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants