Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rclcpp 0.4.0 changes #3

Merged
merged 5 commits into from
Jun 22, 2018
Merged

rclcpp 0.4.0 changes #3

merged 5 commits into from
Jun 22, 2018

Conversation

parthc-rob
Copy link
Contributor

@parthc-rob parthc-rob commented Jun 12, 2018 •
edited

Complementary PR with: ros2_control PR

Maybe we should create branch ardent to have ros2_control versions trackable with rclcpp versions.
@Karsten1987
Current build error -

ros2_ws/src/ros2/ros2_controllers/ros_controllers/src/trajectory.cpp:38:5: error: 
‘now’ is not a member of ‘rclcpp::Time’
     rclcpp::Time::now() :

This was referenced Jun 12, 2018
Closed
Merged
Closed
@parthc-rob parthc-rob mentioned this pull request Jun 20, 2018
Closed
@parthc-rob parthc-rob changed the title [WIP] rclcpp 0.4.0 changes rclcpp 0.4.0 changes Jun 20, 2018
@parthc-rob
Copy link
Contributor Author

parthc-rob commented Jun 20, 2018 •
edited

PR builds successfully with current ros2 master, rclcpp api: ros2/rclcpp@39c22c8

@Karsten1987 Karsten1987 merged commit 079fa27 into ros-controls:master Jun 22, 2018
@zacharyyamaoka zacharyyamaoka mentioned this pull request Mar 19, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Karsten1987 Karsten1987 Karsten1987 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@parthc-rob @Karsten1987