-
Notifications
You must be signed in to change notification settings - Fork 307
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use #pragma once #406
Use #pragma once #406
Conversation
I just wanted to mention here that this pragma is not standard compliant. As most compilers do support it, but as said it’s not in the official standard. |
b76cc3e
to
59f3887
Compare
59f3887
to
b444bcd
Compare
Rebased and updated following #395 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks a lot!
Ah, I am too late for this one.
Not all versions support it and some implementations have serious flaws. |
I would stick to the guidelines: https://github.com/isocpp/CppCoreGuidelines/blob/master/CppCoreGuidelines.md#sf8-use-include-guards-for-all-h-files |
I don't have a strong opinion here, I'm just following #403. Happy to revert to #ifndef guards if that's the consensus of you maintainers. I do wonder how many C++14-compatible compilers don't support |
Part of #403.
Replace all preprocessor header guards with
#pragma once
. Also adds missing header guard totransmission_interface/test/loader_utils.h
. Every.h
file now includes#pragma once
.