Use an explicit relative import path instead of implicit. #471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On python3 system the implicit relative import will not work. The explicit notation, however, should work on python >= 2.5
bmagyar
approved these changes
Aug 17, 2020
bmagyar
pushed a commit
that referenced
this pull request
Aug 17, 2020
On python3 system the implicit relative import will not work. The explicit notation, however, should work on python >= 2.5
|
I've cherry-picked to noetic too and pushing a new release to both noetic and melodic with this, thanks for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On python3 systems the implicit relative import will not work. The explicit
notation, however, should work on python >= 2.5
I am targeting melodic, as I myself am using ROS melodic with a python3 environment. According to REP-0003
noetic-develwould probably be a more appropriate target branch, but it probably wouldn't hurt to include it into melodic, as well.