feat(udp_socket): Optional local_ip #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi reinzor! Very similar implementation we did 2 months ago here: Just wanted to do PR this week, after extensive testing with a pair of motor drives running simultaneously with RPI of about 20ms. It works fine. Thanks Andreu |
|
Hi @andreucm, I did look for PR before creating one but I did not inspect all the forks ;). Anyhow, good that we came up with the same implementation :) |
|
Looks great, thanks. |
|
Can a maintainer make a new release? |
|
Done. Sorry for the exceptionally long delay. As in ros-drivers/omron#14 (comment), this repo is up for adoption if you'd like to make your own releases at a cadence which better suits you. :) Indigo: ros/rosdistro#17426 Kinetic: ros/rosdistro#17427 Melodic: ros/rosdistro#17428 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Optional local ip specification that is used for binding. Default is still
0.0.0.0so we will not break the API.Motivation for this pull request is the use of this library in the
omron_os32_driverpackage. The0.0.0.0binding prevents using multiple scanners on different interfaces, as described in ros-drivers/omron#12