Reorg namespaces #37
Reorg namespaces #37
Conversation
|
@flynneva Good call. Removed |
udp_driver/CMakeLists.txt
Outdated
| @@ -42,11 +50,16 @@ include_directories(include) | |||
| ament_auto_add_library(${PROJECT_NAME} SHARED | |||
| src/udp_socket.cpp | |||
| src/udp_driver.cpp | |||
| examples/udp_driver_node.cpp) | |||
| src/udp_driver_node.cpp) | |||
| ament_target_dependencies(${PROJECT_NAME} "Boost") | |||
|
|
|||
| target_compile_options(${PROJECT_NAME} PUBLIC "-O0" PRIVATE -Wno-sign-conversion -Wno-conversion) | |||
There was a problem hiding this comment.
for consistency with io_context, should this be changed to
| target_compile_options(${PROJECT_NAME} PUBLIC "-O0" PRIVATE -Wno-sign-conversion -Wno-conversion) | |
| target_compile_options(${PROJECT_NAME} PUBLIC "-O0" PRIVATE -Wall |
There was a problem hiding this comment.
This line shouldn't be required at all because CMAKE_CXX_FLAGS should cover that above. Removed.
| ament_target_dependencies(${PROJECT_NAME} "Boost") | ||
|
|
||
| target_compile_options(${PROJECT_NAME} PUBLIC "-O0" PRIVATE -Wno-sign-conversion -Wno-conversion) | ||
|
|
||
| #rclcpp_components_register_node(udp_driver_node |
There was a problem hiding this comment.
assuming you are planning on "compontent-izing" this later?
There was a problem hiding this comment.
Yes. Sorry this got mixed in. Planning on creating two nodes: sender and receiver. They will both be components and managed lifecycle nodes.
udp_driver/CMakeLists.txt
Outdated
| #PLUGIN "drivers::udp_driver::UdpDriverNode" | ||
| #EXECUTABLE ${PROJECT_NAME}_node_exe | ||
| #) | ||
|
|
||
| if(BUILD_TESTING) | ||
| find_package(ament_lint_auto REQUIRED) | ||
| ament_lint_auto_find_test_dependencies() |
There was a problem hiding this comment.
same thing here, do we need the test/gtest_main.cpp similar to what we did within io_context?
There was a problem hiding this comment.
We don't. Removed here and removed the actual file.
Using just the namespace
driversin theudp_driverpackage was too vague. This addsdrivers::commonfor theio_contextpackage anddrivers::udp_driverfor theudp_driverpackage.Also removes some unnecessary destructors.
@flynneva Would you be available to review this?