-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new constructors and members to bind host endpoint #65
Add new constructors and members to bind host endpoint #65
Conversation
@JWhitleyWork I'm sorry, but could you also review this? |
@JWhitleyWork friendly ping |
@wep21 Sorry for the delay on this. I'm not sure I understand why this is necessary. The |
I think it is necessary in case the receiver application specifies the source port which is different from internal endpoint. (Currently the source port is random.)
|
@wep21 I have seen this before also. However, to address it, I would much rather have multiple constructors for
And then have additional parameters for the remote values. Would you be OK with this? |
@JWhitleyWork I think these constructor suits for the use case I suggested. How do you think about it?
|
Yes, your solution looks good to me. |
0379889
to
f2356e7
Compare
Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>
f2356e7
to
c75e749
Compare
@JWhitleyWork I addressed your review at c75e749. |
@JWhitleyWork friendly ping. |
@wep21 Sorry for the delay. I think your solution is mostly fine. However, the remaining issue is that this changes the function of the "default" constructor ( |
@JWhitleyWork I'm sorry, I misunderstood, but I think the issue is that argument of
Do you have any idea to handle this? |
Does this mean that your PR needs changes as well or does this only apply to the current |
Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>
4adec83
to
2a7b349
Compare
@JWhitleyWork friendly ping |
Add bind function with argument to fix source port in sender application as below.