Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proto Quaternion definition #11

Closed
YoshuaNava opened this issue Jun 14, 2018 · 5 comments
Closed

Proto Quaternion definition #11

YoshuaNava opened this issue Jun 14, 2018 · 5 comments
Assignees

Comments

@YoshuaNava
Copy link

YoshuaNava commented Jun 14, 2018

Hej,
In the protobuf definition of Quaternion, it is not very clear to which quaternion dimension each field corresponds, e.g:

Is it the case that

u1 = x
u2 = y
u3 = z
u4 = w

Or

u1 = w
u2 = x
u3 = y
u4 = z

for a quaternion defined as w + x i + y j + z k ?

Thank you.

@jontje
Copy link
Contributor

jontje commented Jun 14, 2018

Hej!

It is the second one:

u1 = w 
u2 = x
u3 = y
u4 = z

It follows the same definition as the RAPID data type orient

@gavanderhoorn
Copy link
Member

@jontje: would this be something to add as a comment in the .proto file?

@jontje
Copy link
Contributor

jontje commented Jun 14, 2018

Definitely, I will do that

@jontje jontje self-assigned this Jun 14, 2018
@gavanderhoorn
Copy link
Member

@jontje: not sure, but I believe this one can be closed looking at:

// Note: Lower priority than Euler angles. The quaternion is defined as: u0 + u1*i + u2*j + u3*k.

@jontje
Copy link
Contributor

jontje commented Apr 11, 2019

@gavanderhoorn: Yes, it can be closed, thanks for the reminder! 👍

@jontje jontje closed this as completed Apr 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

3 participants