Everything was successful: your build exited with 1 - but Travis still says 'failed'

[gavanderhoorn]

Afaict, builds for ros-industrial/abb#89 should be successful, and from the log it would seem they are, but I'm seeing red crosses everywhere and Travis does not seem happy.

That makes me unhappy 😢

I'm not completely up-to-date, but I know you guys are working hard on improving industrial_ci. Could it be that one of the recently merged PRs inverted some logic somewhere?

[gavanderhoorn]

Hm. Or is this:

[abb] Started testing...
find: `install/share/abb': No such file or directory

The cause of those failed builds?

Is this connected with #110?

[mathias-luedtke]

Should be resolved now, please restart your builds :)

[mathias-luedtke]

Could it be that one of the recently merged PRs inverted some logic somewhere?

Nothing inverted here.
industrial_ci used to disable metapackages completely,
#108 removed this strange feature.
The install tests feature was not ready to handle metapackages, but this was not detected because of #101

[mathias-luedtke]

Everything was successful: your build exited with 1

1 means failure in shell logic.
#100 and #103 improved the error propagation, it was broken for certain cases.

[gavanderhoorn]

1 means failure in shell logic.

Yes, I know. Apparently the Everything was successful bit is not about the exit status of the build.

[mathias-luedtke]

So not everthing was successfull. Install tests did fail so it got marked red.
Apart from this bug in industrial_ci, builds will fail for more, previously undetected errors like rosdep failures from now on.

1 means failure in shell logic.

Yes, I know

I have expected that :)

[mathias-luedtke]

Travis is happy again: https://travis-ci.org/ros-industrial/abb/builds/193867890

[gavanderhoorn]

Yep, thanks.