Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Python Interface #38

Merged
merged 24 commits into from Dec 6, 2022
Merged

Add Python Interface #38

merged 24 commits into from Dec 6, 2022

Conversation

marip8
Copy link
Member

@marip8 marip8 commented Dec 6, 2022 •
edited

This PR introduces a Python interface for the reach study class to do the following tasks:

  • Run the reach study, given a YAML file configuration
  • Create pure Python implementations of the reach study interfaces
  • Construct reach study object manually in Python and run the reach study
  • Perform analysis with the reach study results (such as creating reachability heat maps, etc.)

Addresses #6

@marip8 marip8 force-pushed the python_wrap_3 branch 2 times, most recently from 7c4b854 to c2f960e Compare December 6, 2022 00:32
@marip8 marip8 mentioned this pull request Dec 6, 2022
Closed
@marip8 marip8 force-pushed the python_wrap_3 branch 2 times, most recently from 58c1930 to 1be4109 Compare December 6, 2022 00:42
@marip8
Copy link
Member Author

marip8 commented Dec 6, 2022

@collinthornton can you review this PR?

@marip8 marip8 force-pushed the python_wrap_3 branch 3 times, most recently from fd6d5d7 to 9b6a1af Compare December 6, 2022 01:29
collinthornton
collinthornton reviewed Dec 6, 2022
View reviewed changes
Copy link
Contributor

@collinthornton collinthornton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty solid. I pulled the changes down and ran the Python unit tests with no errors.

It looks like the apt installable version of boost_plugin_loader still needs to be updated. We should add the source dependency in a .repos file.

reach/include/reach/interfaces/target_pose_generator.h Outdated Show resolved Hide resolved
.github/workflows/focal_noetic.yml Show resolved Hide resolved
@marip8
Make members of reach study class protected
b9584f7
@marip8
Added Python bindings
40b250e
@marip8
Moved Python bindings of interfaces into separate files; created sepa…
007e7a6 
…rate file for Python utilities
@marip8
Simplified python binding classes/functions
e2e273c
@marip8
Updated Python bindings to utilize updated structures
28af185
@marip8
Use CMake subdirectory for Python code
b9b81f8
@marip8
Updated CMakeLists
aa1806b
@marip8
Fixed free function definitions
1cb8e4b
@marip8
Changed module name and install location
5f30b03
@marip8
Added heat map scripts
d05a9f9
@marip8
Added Python test script
0c812f1
@marip8
Updated boost python object to YAML function
6c38a53
@marip8
Added compile definition for Python build flag
5309dc7
@marip8
Updated file path for local files in unit test
6e52ad4
@marip8
Ran clang-format
19c43e6
@marip8
Revised to/from Eigen utilities
cb8a3d0
@marip8
Added python bindings for heat map colorization functions
eea098a
@marip8
Updated heat map generator script to utilize internal colorization fu…
d8053dc 
…nctions
@marip8
Renamed utils.h to utils.hpp
2335dcd
@marip8
Install Python scripts
30c02d5
@marip8
Copy link
Member Author

marip8 commented Dec 6, 2022

It looks like the apt installable version of boost_plugin_loader still needs to be updated. We should add the source dependency in a .repos file.

Addressed in #39

@marip8 marip8 merged commit 711595d into ros-industrial:master Dec 6, 2022
@marip8 marip8 deleted the python_wrap_3 branch December 6, 2022 20:01
@marip8 marip8 mentioned this pull request Dec 8, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@collinthornton collinthornton collinthornton left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@marip8 @collinthornton