Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UR30 description and meshes #674

Merged
merged 11 commits into from
Mar 15, 2024
Merged

UR30 description and meshes #674

merged 11 commits into from
Mar 15, 2024

Conversation

VinDp
Copy link
Contributor

@VinDp VinDp commented Feb 25, 2024

I backported everything from ROS2, so the meshes are also here under the same license terms.
@fmauch @urrsk

Copy link
Contributor

@fmauch fmauch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In total this looks fine, I've tested viewing the model and using it with the ur_robot_driver on a URSim robot and launching gazebo. In Gazebo the robot falls to the ground initially, but I think that's the same for other models at the moment.

The license version probably should get straightened out as mentioned in my comment, I assume @urrsk would agree with that.

ur_description/meshes/ur30/LICENSE.txt Show resolved Hide resolved
Copy link
Contributor

@fmauch fmauch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, that looks good now.

@fmauch fmauch merged commit 0290bd2 into ros-industrial:noetic-devel Mar 15, 2024
4 checks passed
@urrsk
Copy link
Contributor

urrsk commented Mar 18, 2024

Thanks @VinDp and @fmauch

@VinDp VinDp deleted the ur30 branch March 20, 2024 10:13
@fmauch fmauch mentioned this pull request Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants