Unused min/max_payload parameters

[miguelprada]

This package's launch files expose min_payload and max_payload arguments, which are used to set equally named parameters, but those parameters are not used anywhere.

[gavanderhoorn]

Those were supported in the master version (which got it from ur_driver), but apparently @Zagitta didn't implement the checks:

ur_modern_driver/include/ur_modern_driver/ros/io_service.h

Lines 65 to 70 in 77fa08a

	bool setPayload(ur_msgs::SetPayloadRequest& req, ur_msgs::SetPayloadResponse& resp)
	{
	LOG_INFO("setPayload called");
	// TODO check min and max payload?
	return (resp.success = commander_.setPayload(req.payload));
	}

[gavanderhoorn]

I added help wanted as this could be a good first issue for someone to tackle.

[gavanderhoorn]

Did you make any progress here @ben-greenberg?

[ben-greenberg]

I have made progress but some further work and testing is still needed. I will be continuing my work on this.

[gavanderhoorn]

I'm going to unassign this @ben-greenberg.

You're welcome to keep working on it of course.