Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid separator in SetPayload srv #10

Merged
merged 1 commit into from
Nov 12, 2020

Conversation

Briancbn
Copy link
Member

@Briancbn Briancbn commented Nov 12, 2020

I know this will potentially break a lot of things, so maybe this doesn't need to be merged at this moment, but the current field name and separator will not be able to build in ROS2 or a ROS1-ROS2 bridge.
Changes:

  • License and DCO
  • Change field name to fit ROS2 regex check
  • fix invalid separator

@gavanderhoorn
Copy link
Member

Thanks for the PR.

Could you please only include 3308c36 in this PR? The others seem unrelated to the problem you report.

@gavanderhoorn
Copy link
Member

Did you keep 38d0b36 on purpose?

I understand why you did it, but that change will indeed break all sorts of software, and does not follow the naming of the field in RTDE.

Signed-off-by: Chen Bainian <chenbn@artc.a-star.edu.sg>
@Briancbn Briancbn changed the title Invalid separator and field name in ROS2 Invalid separator in SetPayload srv Nov 12, 2020
@Briancbn
Copy link
Member Author

I understand why you did it, but that change will indeed break all sorts of software, and does not follow the naming of the field in RTDE.

Noted, I change this PR to only fixing the separator.

Copy link
Member

@gavanderhoorn gavanderhoorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix.

That should indeed have been just ---. Interesting we didn't see any warnings from the .msg parser.

@gavanderhoorn gavanderhoorn merged commit 7385b7d into ros-industrial:melodic Nov 12, 2020
@gavanderhoorn
Copy link
Member

Oh. I just noticed you opened this against melodic, which is the release branch.

It should've been opened against melodic-devel.

I'll revert melodic and push the commit to melodic-devel.

gavanderhoorn pushed a commit that referenced this pull request Nov 12, 2020
Signed-off-by: Chen Bainian <chenbn@artc.a-star.edu.sg>
@gavanderhoorn
Copy link
Member

Fixed.

I'll create a release later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants