Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change "payload" field name to "mass" #5

Merged
merged 1 commit into from
Jun 24, 2020
Merged

Change "payload" field name to "mass" #5

merged 1 commit into from
Jun 24, 2020

Conversation

fmauch
Copy link
Contributor

@fmauch fmauch commented Jun 24, 2020

Followup on #2

Since we extended this service to also contain the cog, IMHO it makes sense to rename the "payload" field to "mass" as it is named inside UR's documentation.

@fmauch
Change "payload" field name to "mass"
750c7c3 
Since we extended this service to also contain the cog, IMHO it makes sense
to rename the "payload" field to "mass" as it is named inside UR's documentation.
gavanderhoorn
gavanderhoorn approved these changes Jun 24, 2020
View reviewed changes
Copy link
Member

@gavanderhoorn gavanderhoorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with this, but this will break ur_modern_driver.

It's deprecated and targets Kinetic only, but I can see people running into issues with it now that ur_msgs is released for Melodic.

@gavanderhoorn gavanderhoorn merged commit d92172f into ros-industrial:melodic-devel Jun 24, 2020
@fmauch fmauch deleted the update_payload_service branch June 24, 2020 15:39
@Doomerdinger Doomerdinger mentioned this pull request Sep 4, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gavanderhoorn gavanderhoorn gavanderhoorn approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@fmauch @gavanderhoorn