use version number on -modules dependency #122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 26, 2018
tfoote
approved these changes
Jul 27, 2018
mikepurvis
reviewed
Jul 27, 2018
| ; rosdistro-modules same version as in: | ||
| ; - setup.py | ||
| ; - src/rosdistro/__init__.py | ||
| Depends3: ca-certificates, python3-rosdistro-modules (>= 0.6.8), python3-setuptools, python3-yaml |
There was a problem hiding this comment.
It's annoying stdeb doesn't have a "same version" value that can be put here and have automatically replaced. :(
There was a problem hiding this comment.
The whole -modules thing is pretty hacky. I don't think any other package does what we do here. I am more surprised that is no better approach to release a package for Python 2 and Python which are side-by-side installable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the version number on the dependency on the
-modulespackage to ensure that the-modulespackage gets updated too.This will address the problem described in https://answers.ros.org/question/245967/importerror-no-module-named-rospkg-python3/
The same patch will be necessary for
catkin_pkg,rospkgandros_buildfarm.