Support for sphinx-tabs extension #191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
hidmic
changed the title
|
Is it feasible to upstream your change? |
I can send a PR upstream and wait. We also do not know how often the author / maintainer / owner releases. Edit: see executablebooks/sphinx-tabs#53. |
tfoote
approved these changes
Nov 12, 2019
|
Ok, I'll merge this to get things going and make a follow-up PR when and if the patch is accepted upstream and released to PyPi. |
tfoote
added a commit
that referenced
this pull request
May 13, 2021
Partial rollback of #191 This relies on ros2/ros2_documentation#1518 Our fork is out of date and isn't compatible with the new 4.x sphinx
Merged
tfoote
added a commit
that referenced
this pull request
May 13, 2021
Partial rollback of #191 This relies on ros2/ros2_documentation#1518 Our fork is out of date and isn't compatible with the new 4.x sphinx
tfoote
added a commit
to tfoote/sphinx-tabs
that referenced
this pull request
May 13, 2021
It's been removed from https://github.com/ros-infrastructure/rosindex ros-infrastructure/rosindex#268 Where this was created for It's been removed from https://github.com/ros-infrastructure/rosindex ros-infrastructure/rosindex#191
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #187. Depends on a
sphinx-tabsfork of mine. As a proof of proper functionality, see below: