Hide eol distros

[mikaelarguedas]

This PR is a replacement for previously reverted #169

• uses loaded distributions to generate Package and Stack headers
• uses the already existing list of active distributions (distro_names_buildfarm) to create the ros version selector

Pros:

• remove modification of imported "distro_names" in all modules using it
• display only active distros on all wiki pages
• keep compatibility with macros passed argument using eol distros (e.g. groovy_and_newer), fixe X_and_newer version selectors don't work for X <- EOLd distros #197

Cons:

• no way for user to access wiki pages for not displayed distros

Alternative:
Create a checkbox "display EOL distros" next to the version selector that adds back all distros to the version selector and allow to access content for all of them

[wjwwood]

The code changes lgtm.

But, this:

• no way for user to access wiki pages for not displayed distros

Seems like a pretty big con to me. I don't know how others feel about it, but I'm hesitant to move forward without the ability to access the wiki blocks for older distributions.

[tfoote]

In the meeting we talked about refactoring this to hide the EOL'd distro selectors, but not completely disable them.

[mikaelarguedas]

Delaying this until less radical approach is implemented

[dhood]

hey @mikaelarguedas and/or @wjwwood @tfoote, how were you testing this PR?

I have a local instance of the wiki, and was going to create a test page that uses that macro, but first I have to create a user and I haven't been able to do that successfully yet (haven't tried disabling the whitelist yet)

Did you test on a local instance, or just on the live one?

[mikaelarguedas]

I was testing live for short time periods

[dhood]

ok, thanks!

changed the approach and @dhood is implementing the alternative

[dhood]

• Now there's a checkbox that is unchecked by default but if checked, the version selector for eol distros appears.

• content-embedding macros for all distros are supported (e.g. diamondback_and_newer can be used even though it doesn't have a version selector).

• If the distro selected in the url is an EOL distro, the eol selector is displayed on page load.

• If a package has only been released into eol distros, the checkbox isn't there.

example stack header with only some distros released (eol distros are hidden by default)

---

example stack header with only EOL distros released

---

example Version() (eol distros are hidden by default)

[dhood]

I just took a guess at why these distros are being excluded from the macros, open to suggestions for a more appropriate variable name if there is one

[dhood]

With jade removed from the non-EOL list, Version header looks like:

by default:

expanded:

[dhood]

I actually think that cturtle and diamondback have been removed from the version selector by accident somewhere along the line (@mikaelarguedas pointed out all files are modifying the global distro_names, so that would do it).

Our ubuntu installation page has code to load the cturtle/diamondback installation pages: http://wiki.ros.org/Installation/Ubuntu (which it can't do currently because the version selector starts at electric).

I definitely think that we should restore support for macros referencing older distros e.g. http://wiki.ros.org/image_transport has a section using diamondback_and_newer that is not currently being displayed. This PR does that. But, do we also want to add cturtle and diamondback back to the (EOL) version selector?

---

btw this is the contents of the wiki page I previously posted screenshots for, which is what's making the text show up:

<<Version()>>

{{{{#!wiki version kinetic
$ROS_DISTRO
}}}}

{{{{#!wiki version diamondback_and_newer
as of diamondback
}}}}
{{{{#!wiki version indigo_and_newer
as of indigo
}}}}

And the following for PackageHeader (I'm testing on a dummy wiki which is why it gives index errors):

<<PackageHeader(rviz)>>

{{{{#!wiki version kinetic
$ROS_DISTRO
}}}}

{{{{#!wiki version diamondback_and_newer
`my_api()` <<Version(ROS diamondback)>>
}}}}

[dhood]

This PR now highlights that EOL distros are EOL.

Version() macro:

PackageHeader:

[dhood]

@tfoote @mikaelarguedas @wjwwood could any of you (re)review this if you get a chance