Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more oe deps #106

Merged
merged 4 commits into from Dec 28, 2017
Merged

Add more oe deps #106

merged 4 commits into from Dec 28, 2017

Conversation

allenh1
Copy link
Collaborator

@allenh1 allenh1 commented Dec 21, 2017

This adds some deps for Open Embedded, as well as fixes some of the builds.

After this branch is merged, I think we'll do a release. This branch will be ready when catkin is cooperating completely.

@allenh1 allenh1 self-assigned this Dec 21, 2017
@allenh1
Copy link
Collaborator Author

allenh1 commented Dec 26, 2017

Ok, there's still some problems. Currently, I'm pretty sure there isn't anything to do in superflore to help with this. I think there's just some tweaking to be done in the meta-ros repo.

Newest build failure log is here.

Currently, ros_comm/rosbag_storage fails with some macro problem, likely just a missing include folder somewhere. Should be an easy fix.

There's an inability to find empy at the moment, despite it being installed in /usr/lib/python2.7/site-packages. Since there's no default empy installer for OE (in fact the only recipe is located in the meta-ros repo), I might just modify the empy installer to install in /opt/ros/[distro]/lib/python2.7/site-packages like the rest of the ROS packages. @tfoote what do you think about that?

@allenh1 allenh1 requested a review from tfoote December 26, 2017 20:34
@tfoote
Copy link
Member

tfoote commented Dec 28, 2017

I'd rather see the OE installer for empy work in /usr/lib as we don't want to start duplicating all system dependencies into /opt/ros/* but if that will get things going for now that would be fine. Though if you do that please open a ticket to track pulling it back out. And that would be a good recipie to work toward pushing it to an upstream source like the debian packages we use so that they'll be available more generally.

@allenh1
Copy link
Collaborator Author

allenh1 commented Dec 28, 2017

I'd rather see the OE installer for empy work in /usr/lib as we don't want to start duplicating all system dependencies into /opt/ros/* but if that will get things going for now that would be fine.

No need! I figured out how to add it to PYTHONPATH, and all is now well with detecting empy.

@allenh1 allenh1 merged commit 5f354d6 into master Dec 28, 2017
@allenh1 allenh1 deleted the add-more-oe-deps branch December 28, 2017 19:15
@tfoote tfoote mentioned this pull request Dec 28, 2017
Open
zffgithub pushed a commit to zffgithub/superflore that referenced this pull request Apr 11, 2023
@allenh1
Add more oe deps (ros-infrastructure#106)
f8edd3d 
* Add definition for libpoco-dev

* Use the ROSDISTRO variable to name distros during install

* Add catkin _and_ catkin-native for catkin dep resolution.

* Don't build in binary mode if we are building catkin
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tfoote tfoote tfoote approved these changes

Assignees

@allenh1 allenh1

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@allenh1 @tfoote @herb-kuta-lge