Change operation for OpenEmbedded when --only is specified (#224) #233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
herb-kuta-lge
force-pushed
the
recipes-only-if--only-option-224
branch
2 times, most recently
from
ca6e21a
to
982e11b
Compare
allenh1
reviewed
Nov 19, 2019
| @@ -45,8 +45,11 @@ def commit_changes(self, distro, commit_msg): | |||
| 'files/{0}/newer-platform-components.list'.format(distro)) | |||
| self.repo.git.add( | |||
| 'files/{0}/superflore-change-summary.txt'.format(distro)) | |||
| info('Committing to branch {0}...'.format(self.branch_name)) | |||
| self.repo.git.commit(m=commit_msg) | |||
| if self.repo.git.status('--porcelain') == '': | |||
There was a problem hiding this comment.
Could you please add this behavior to the Gentoo generator as well?
There was a problem hiding this comment.
Sure. I'll move this into a separate commit and add the change for the Gentoo generator (and create a new issue).
There was a problem hiding this comment.
The new issue is #245.
herb-kuta-lge
force-pushed
the
recipes-only-if--only-option-224
branch
from
982e11b
to
a2ae3c8
Compare
|
Hi @allenh1 is there anything blocking this PR? We're almost ready to publish updated meta-ros with recipes generated with superflore modified with all these open PRs and it would be nice to have it in superflore/master before we do. |
herb-kuta-lge
force-pushed
the
recipes-only-if--only-option-224
branch
2 times, most recently
from
de6b088
to
7b6d40d
Compare
shr-project
previously approved these changes
Dec 3, 2019
allenh1
reviewed
Dec 4, 2019
herb-kuta-lge
force-pushed
the
recipes-only-if--only-option-224
branch
from
7b6d40d
to
a795544
Compare
- The files under conf and files created by superflore-gen-oe-recipes are only useful when all of the recipes for a ROS distro are being generated => don't generate them when --only is specified. - Use a slighly different commit message when --only is specified. - This commit resolves issue ros-infrastructure#224.
herb-kuta-lge
force-pushed
the
recipes-only-if--only-option-224
branch
from
a795544
to
26ed7fa
Compare
|
@allenh1 < Rebased to current HEAD of |
zffgithub
pushed a commit
to zffgithub/superflore
that referenced
this pull request
Apr 11, 2023
…structure#233) - The files under conf and files created by superflore-gen-oe-recipes are only useful when all of the recipes for a ROS distro are being generated => don't generate them when --only is specified. - Use a slighly different commit message when --only is specified. - This commit resolves issue ros-infrastructure#224.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The files under conf and files created by superflore-gen-oe-recipes
are only useful when all of the recipes for a ROS distro are being
generated => don't generate them when --only is specified.
Use a slightly different commit message when --only is specified.