generators: add --no-branch option to prevent creating new local branch (#248) #249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shr-project
force-pushed
the
jansa/no-branch
branch
from
0953642
to
f161a48
Compare
allenh1
reviewed
Nov 19, 2019
superflore/generators/bitbake/run.py
Outdated
| @@ -93,7 +93,8 @@ def main(): | |||
| overlay = RosMeta( | |||
| _repo, | |||
| not args.output_repository_path, | |||
| branch='superflore/{}'.format(now), | |||
| branch=(('superflore/{}'.format(now)) if not args.no_branch | |||
| else None), | |||
There was a problem hiding this comment.
@shr-project the linter is unhappy with this line
There was a problem hiding this comment.
Looking into it now (before the line was too long now this.. :))
There was a problem hiding this comment.
before the line was too long now this.. :)
Haha, yeah. Welcome to superflore changes ;). Linter is pretty picky.
|
Fixes #248 |
shr-project
force-pushed
the
jansa/no-branch
branch
from
f161a48
to
3302c1e
Compare
shr-project
force-pushed
the
jansa/no-branch
branch
from
3302c1e
to
8f09e9a
Compare
|
Hi @allenh1 is there anything blocking this PR? We're almost ready to publish updated meta-ros with recipes generated with superflore modified with all these open PRs and it would be nice to have it in superflore/master before we do. |
allenh1
reviewed
Dec 3, 2019
allenh1
reviewed
Dec 3, 2019
allenh1
reviewed
Dec 3, 2019
allenh1
reviewed
Dec 3, 2019
allenh1
requested changes
Dec 3, 2019
* useful when regenerating the files locally by hand without planing to submit PR with the changes or when some other tool will do additional integration before doing the PR (like we plan to do with meta-ros) Signed-off-by: Martin Jansa <martin.jansa@lge.com>
shr-project
force-pushed
the
jansa/no-branch
branch
from
8f09e9a
to
6aa9b53
Compare
allenh1
approved these changes
Dec 3, 2019
zffgithub
pushed a commit
to zffgithub/superflore
that referenced
this pull request
Apr 11, 2023
…ch (ros-infrastructure#249) * useful when regenerating the files locally by hand without planing to submit PR with the changes or when some other tool will do additional integration before doing the PR (like we plan to do with meta-ros) Signed-off-by: Martin Jansa <martin.jansa@lge.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR with the changes or when some other tool will do additional
integration before doing the PR (like we plan to do with meta-ros)
Signed-off-by: Martin Jansa martin.jansa@lge.com