Skip to content
This repository has been archived by the owner on Feb 11, 2022. It is now read-only.

Update architecture list for ros-melodic-cpp #2

Closed
acxz opened this issue Nov 9, 2019 · 15 comments
Closed

Update architecture list for ros-melodic-cpp #2

acxz opened this issue Nov 9, 2019 · 15 comments

Comments

@acxz
Copy link
Member

acxz commented Nov 9, 2019

No description provided.

@bionade24
Copy link
Member

Why shouldn't we provide any? I build on i686, amd64, armhf and arm64, everything worked. I hate the AUR maintainers which do this for no reason, like console-bridge (I'm not sure if I remember correctly). You always have to edit to make it arm compatible.

@acxz
Copy link
Member Author

acxz commented Nov 9, 2019

I think the reason is that if the compiled package is architecture specific, then we need to specify which architectures.
Here is what the Arch Wiki says:
https://wiki.archlinux.org/index.php/Arch_package_guidelines#Architectures

@bionade24
Copy link
Member

bionade24 commented Nov 9, 2019

Ok, I tought this would be done by automatically by makepkg. Will build it into the PKGBUILD generator tomorrow, so packages that use cmake have i686, x86_64, armhf and arm64 in the array.
Edit: arch=('i686' 'x86_64' 'aarch64' 'armv7h' 'armv6h')

@acxz
Copy link
Member Author

acxz commented Nov 9, 2019

Sweet thx!

@acxz
Copy link
Member Author

acxz commented Feb 4, 2020

@bionade24 Should we also add arm? https://wiki.archlinux.org/index.php/PKGBUILD#arch

Also what is the status of this currently?

@bionade24
Copy link
Member

armv5 is older than the pi1, no one should even try building ROS on it, all processors probably have >=500Mhz, so no.
Status: As I now have to rebuild my private Repo because of the boost updates, I'll updates everything with @jwhendy script I fixed & refactored to fit better. I'm currently not finished with this because I not even just want to correct the arch array, I also want to add tests.

@bionade24
Copy link
Member

I currently struggle with adding tests. Do you have an idea? https://discourse.ros.org/t/who-is-using-ros-on-archlinux/388/29

@acxz
Copy link
Member Author

acxz commented Feb 12, 2020

Sadly, I am actually not familiar with tests in ROS.

@jwhendy
Copy link
Contributor

jwhendy commented Feb 12, 2020

Same here (no experience at all).

Also, finally recovering from not 1, not 2, but 3 hard drive issues so I haven't done much of anything on ROS in a while as I got that sorted. @bionade24 per our earlier btrfs discussion, I suspect it could have been related to continuous trim after all (discard in fstab and luks.options) or a kernel clash with respect to samsung 850 ssds dm-crypt. If you want to read the saga, here it is. My newer nvme is saved and healed but my SSD (5yrs old) is likely not recoverable.

@bionade24
Copy link
Member

I read it. As the 850's problem should not have been occured on the nvme and the cache is changing a lot, I think it's really somehow caused by bugs in the continious TRIM feature. I future you probably should scrub regularly and maybe as a nicer backup solution you could export the subvolumes directly, btrbackup is a nice script for this task.

I'll investigate further how test can be done in plain cmake, but for now I'll simply will fix the arch arrays.

@bionade24
Copy link
Member

As I have to rebuild every package because of the boost updates, I finally got myself to do this, everything containing c++ code should now have a correct arch array. Maybe me detection method is really bad, but I didn't want to extract and parse the CMakeLists.txt out of every package. Sorry additionally for not mention the deletion of the unnecessary python flags. If you find any packages where my script handled wrong, please open issues.
About arch4edu: @acxz Could you maybe wait with doing this? As gmock still links against python2 and the maintainer felix is much to busy, I'll try to become a TU(I should already have enough TUs that will suggest me). So additionally to the gtest packages I'll try to get at least ros-melodic-desktop and its dependencies into community repo, so that the core stack is dowlodable without discovering arch4edu.

@acxz
Copy link
Member Author

acxz commented Feb 15, 2020

That's great! Great work on this man, you are really killing it!
Yeah if we can get into the community repo that would be much better!
Can you post a link to where your script is? Sorry but I can't seem to find it.
And yeah for sure, you know I will be testing the build process left and right. Def not afraid to post issues lol.
Congrats man, can't wait to rebuild ROS once the updated PKGBUILDS get onto the AUR.

@bionade24
Copy link
Member

Here they are. As I already warned you, they're shitty. ;)

@acxz
Copy link
Member Author

acxz commented Feb 15, 2020

No no, not bad man.
When/how long do you think these changes will be reflected in the AUR? I assume they have to go through your build process?

One thing I can see is that some packages (these in fact ros-melodic-arch/ros-melodic-desktop-full#8) do rely on those CMake flags. But we can resolve those once we run into them.

@bionade24
Copy link
Member

Yes, builds are ongoing, some things should already be compiled/pushed. Afterwards completing this my binary repo should work with latest boost, too.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants