Added support for connecting to local broker #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hi, oyu need to rebase to get that PR valid, thx. |
By doing this the nodelet can connect to a local broker allowing direct function calls and memory access. Note that the nodelet will prefer the local broker over one specified on the command line or using ros parameters.
|
Rebased. |
| @@ -112,6 +112,12 @@ namespace naoqicamera_driver | |||
| diagnostic_updater::TimeStampStatusParam()) | |||
| { | |||
| getNaoqiParams(priv_nh); | |||
There was a problem hiding this comment.
shouldn't we try to connect to the NAOqi with the parameters first ? (and if that fails try the local one)
|
@jondy276 , shouldn't we try to connect to the NAOqi with the parameters first ? (and if that fails try the local one) |
|
ping ? |
|
Sorry, lot of things to do. |
|
Allso, I have a prototype naoqi module that allows nodelets to be loaded. |
|
lg2m. We have nothing to load nodelets in a naoqi module so sure, make it more fun :) |
vrabaud
added a commit
that referenced
this pull request
Nov 21, 2014
Added support for connecting to local broker
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By doing this the nodelet can connect to a local broker allowing
direct function calls and memory access.
Note that the nodelet will prefer the local broker over one
specified on the command line or using ros parameters.