Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/stereo #111

Merged
merged 7 commits into from May 10, 2019
Merged

Feature/stereo #111

merged 7 commits into from May 10, 2019

Conversation

mbusy
Copy link
Member

@mbusy mbusy commented May 9, 2019

On Pepper 1.8, the depth information is reconstructed from the stereo information provided by 2 RGB cameras (each RGB camera is located behind each eye, the left eye is used as referential).

This PR makes naoqi_driver compatible with Pepper 1.8 and ensures its compatibility with the previous versions of the robot. On a 1.8 robot, the user will now be able to access to:

  • The depth image reconstructed from the stereo
  • The raw images coming from the stereo cameras

@nlyubova
Copy link
Member

nlyubova commented May 9, 2019

hey, great that you've done it !

@severin-lemaignan
Copy link
Contributor

Thanks for contribution!
After a first cursory check, it looks ok to me (I haven't tested the code, though).

Could you add somewhere a debug message telling the user which version of the robot has been detected? (like 'Pepper 1.8', 'Pepper 1.6', 'Pepper 1.8a', etc)

@mbusy
Copy link
Member Author

mbusy commented May 9, 2019

You're welcome, we needed it anyway, so why not share it with the community :) Sure, I could add that in the initial logs

@severin-lemaignan
Copy link
Contributor

@nlyubova any chance you can test the code before we merge?

@nlyubova
Copy link
Member

nlyubova commented May 9, 2019

@severin-lemaignan Sorry, I don’t have Pepper.

@mbusy
Copy link
Member Author

mbusy commented May 10, 2019

I was able to test it on a Pepper 1.8 and on a Pepper 1.8A, it was working fine. If an additional tester is required, I think that @zygopter could have access to some Peppers :)

@severin-lemaignan
Copy link
Contributor

We'll trust you on that one ;-) Merging now. Thanks!

@severin-lemaignan severin-lemaignan merged commit 2fa8d91 into ros-naoqi:master May 10, 2019
@mbusy mbusy deleted the feature/stereo branch May 10, 2019 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants