Add rosdep step to manual build instructions #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
SteveMacenski
requested changes
Jul 10, 2020
build_instructions/index.rst
Outdated
| colcon build --symlink-install --cmake-args -DCMAKE_BUILD_TYPE=Release | ||
|
|
||
| Note: You need to change ``--rosdistro`` to the selected ROS 2 distribution name (e.g ``eloquent``, ``foxy``). |
There was a problem hiding this comment.
Please remove the (e.g ...) from both, I don't like naming specific distributions, it can get out of date quickly.
There was a problem hiding this comment.
Done on 90c9975
|
@MiguelCompany pinging - please make those small updates so we can merge |
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
SteveMacenski
approved these changes
Jul 30, 2020
|
Thanks for the help! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #39
Signed-off-by: Miguel Company MiguelCompany@eprosima.com