Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Register nodes as components + launch files to use component container #1013

Closed
bpwilcox opened this issue Aug 7, 2019 · 3 comments
Closed
Labels
2 - Medium Medium Priority

Comments

@bpwilcox
Copy link

bpwilcox commented Aug 7, 2019

Feature request

Make all nodes components with default launch files using the component container to load into the same process (or at least optional launch file along with the distributed one)

Need to register them and then make a launch file using them.

Feature description

We've discussed the potential for the stack to be configured into different processes by utilizing components in ROS2, yet none of our nodes have been registered as components. We should make this change to enable this use case.

See https://index.ros.org/doc/ros2/Tutorials/Composition/

Implementation considerations

  • Components need to have NodeOptions as the constructor argument, not sure what impact that has on the signature of the nodes in the stack.
@shivaang12
Copy link
Collaborator

shivaang12 commented Jan 15, 2020

Do you have any high level plan of how you want to approach this? I think we might need to split the nodes in order to make them compatible for running standalone as well as through component.

@SteveMacenski
Copy link
Member

They should all work to my knowledge just registering in the CMakelists and with the cpp macros. They all derive from the node type and take in NodeOptions.

@SteveMacenski SteveMacenski changed the title Register nodes as components Register nodes as components + launch files to use component container Aug 11, 2020
@SteveMacenski SteveMacenski changed the title Register nodes as components + launch files to use component container Register nodes as components + launch files to use component container [blocked by launch lifecycle-components] Aug 23, 2021
@SteveMacenski SteveMacenski changed the title Register nodes as components + launch files to use component container [blocked by launch lifecycle-components] Register nodes as components + launch files to use component container Sep 14, 2021
@gezp gezp mentioned this issue Sep 15, 2021
6 tasks
@SteveMacenski
Copy link
Member

PR open and to be merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2 - Medium Medium Priority
Projects
None yet
Development

No branches or pull requests

4 participants