Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get starting pose from localization #47

Closed
mjeronimo opened this issue Sep 5, 2018 · 4 comments
Closed

Get starting pose from localization #47

mjeronimo opened this issue Sep 5, 2018 · 4 comments
Assignees
Labels
1 - High High Priority enhancement New feature or request nav2_bt_navigator Behavior tree version of the navigator

Comments

@mjeronimo
Copy link

Currently, the robot's starting pose is stubbed out in the BtNavigator and SimpleNavigator classes. Instead, it should come from the Localization module.

@mjeronimo mjeronimo added nav2_bt_navigator Behavior tree version of the navigator nav2_simple_navigator labels Sep 5, 2018
@mjeronimo mjeronimo self-assigned this Sep 5, 2018
@mjeronimo mjeronimo added this to the September 2018 milestone Sep 7, 2018
@mkhansenbot mkhansenbot added the enhancement New feature or request label Sep 17, 2018
@mkhansenbot mkhansenbot removed this from the September 2018 milestone Oct 10, 2018
@mkhansenbot mkhansenbot added this to the November 2018 milestone Oct 29, 2018
@mjeronimo
Copy link
Author

Both navigator classes now get the current robot pose from the Robot class, which receives it from AMCL via the amcl_pose topic.

@SteveMacenski
Copy link
Member

@mjeronimo that's not the current pose, you should be checking TF for the current pose. That will only run every once in awhile (every 20cm or so) which isn't up to date or particularly accurate at any given time.

This is why folks use robot_pose_ekf, robot_localization, etc in order to get high rate accurate (according to model) pose estimates

@mkhansenbot mkhansenbot reopened this Nov 12, 2018
@mkhansenbot mkhansenbot added the 1 - High High Priority label Nov 12, 2018
@mikeferguson
Copy link
Contributor

mikeferguson commented Nov 13, 2018

I'm just going to add a comment here for clarity: AMCL itself will only update every so often -- which means that the odom->map transform only gets updated occasionally. In theory, the odom->map shouldn't change quickly (unless you are slipping wheels/etc).

The base_link->odom should be updating at the rate of the base controller odom/tf publication, which should be much higher (alternatively, the base controller might not publish TF, but rather let something like robot_localization fuse the base odometry and IMU to get a more accurate base_link->odom TF publication).

TF is still the right way to get the base_link->map transformation though.

@mkhansenbot
Copy link
Collaborator

Let's open a new issue for the change to use TF for the initial starting pose

ghost referenced this issue in logivations/navigation2 Mar 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1 - High High Priority enhancement New feature or request nav2_bt_navigator Behavior tree version of the navigator
Projects
None yet
Development

No branches or pull requests

4 participants