Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use action client get result method #923

Closed
orduno opened this issue Jul 11, 2019 · 1 comment
Closed

Use action client get result method #923

orduno opened this issue Jul 11, 2019 · 1 comment
Assignees
Labels
1 - High High Priority

Comments

@orduno
Copy link
Contributor

orduno commented Jul 11, 2019

Multiple places use the ClientGoalHandle.async_result() to get the action result. However, it seems safer to use Client.async_get_result(), plus that way we don't have to provide an empty lambda function to make it result aware.

That seems to be the intended use.

@orduno orduno added the 2 - Medium Medium Priority label Jul 11, 2019
@orduno orduno added this to the D Turtle Release milestone Jul 11, 2019
@orduno orduno self-assigned this Jul 11, 2019
@orduno orduno added this to Incoming Issues in Navigation 2 Kanban via automation Jul 11, 2019
@orduno orduno removed their assignment Jul 11, 2019
@orduno
Copy link
Contributor Author

orduno commented Jul 11, 2019

This could be a possible source of errors, so I'm going to promote it high.

@orduno orduno added 1 - High High Priority and removed 2 - Medium Medium Priority labels Jul 11, 2019
@crdelsey crdelsey removed this from Incoming Issues in Navigation 2 Kanban Jul 17, 2019
@orduno orduno self-assigned this Oct 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1 - High High Priority
Projects
None yet
Development

No branches or pull requests

3 participants