[Dashing] Fix the build due to access specifiers #1039
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No idea why this builds under GCC but these changes were needed to build under clang.
rotu
changed the title
|
We generally batch sync dashing with changes we want to dump in dashing before a release #1040 will be ported back to dashing next time we sync on that. But @mkhansen-intel might have other thoughts. |
|
Okay. Feel free to close this PR if that's the case. |
|
Next batch sync is the 26th (give or take). We're trying to do it monthly. If this is blocking you, I'm ok with merging this in sooner, since it is low risk. |
|
@crdelsey Not blocking me particularly. However works best for you guys. |
|
The 'E' PR was merged, so we can add it in that batch then, closing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No idea why this builds under GCC but these changes were needed to build under clang.