Removing ament_copyright linter from test set #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjeronimo
approved these changes
Sep 26, 2018
|
It looks like it is the ament_copyright linter that has the non-standard text. I've file an issue in that repo |
mhpanah
approved these changes
Sep 28, 2018
Due to a difference in the wording of the copyright template in the linter and the one actually used in the source, the linter fails these files. To resolve that problem, I'm removing the copyright linter from the test set.
crdelsey
force-pushed
the
dwb_copyright_linter_fix
branch
from
b53d569
to
c54eb54
Compare
|
There is a better approach to this to not prevent additional future linters to be picked up. See the example in the package template: https://github.com/ros2/ros2cli/blob/2049b2fb8ae8f00ad34ad6957fd27ca480b28884/ros2pkg/ros2pkg/resource/ament_cmake/CMakeLists.txt.em#L88-L95 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to a difference in the wording of the copyright template in the
linter and the one actually used in the source, the linter fails
these files.
To resolve that problem, I'm removing the copyright
linter from the test set.Unfortunately, the only way to do that is to
include every linter but the copyright one.