Amcl ctest fix #114
Merged
Amcl ctest fix #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Will re-open this PR after PR #105 is reviewed. |
Merged
…into amcl_ctest_Fix
mjeronimo
approved these changes
Sep 28, 2018
crdelsey
reviewed
Sep 28, 2018
| @@ -20,9 +20,15 @@ | |||
|
|
|||
| /* Author: Brian Gerkey */ | |||
|
|
|||
| #include <boost/foreach.hpp> | |||
There was a problem hiding this comment.
There shouldn't be a need for this header. std has a suitable for statement now.
There was a problem hiding this comment.
I will address this issue on a separate PR.
| @@ -391,7 +408,7 @@ void AmclNode::reconfigureCB(AMCLConfig & config, uint32_t level) | |||
| pf_ = pf_alloc(min_particles_, max_particles_, | |||
| alpha_slow_, alpha_fast_, | |||
| (pf_init_model_fn_t)AmclNode::uniformPoseGenerator, | |||
| (void *)map_); | |||
| <void *>(map_)); | |||
There was a problem hiding this comment.
What's happening here? This doesn't look like valid syntax to me. You've somehow converted a cast to void* into a template parameter of nothing, or am I reading this wrong?
Ah. It looks like this is missing the reinterpret_cast that you used below.
There was a problem hiding this comment.
Yes, it's missing the reinterpret_cast. Thanks.
Adding reinterpret_cast to line 411 to fix casting typo.
crdelsey
approved these changes
Sep 29, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The copyright template is not available and therefore I removed the copyright linter from the test. I've also removed the flake8 due to not checking the files correctly.
Addressing issue #109.