Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 1608 segmentation fault planner server node master (#1612) #1767

Merged
merged 1 commit into from
May 27, 2020
Merged

Issue 1608 segmentation fault planner server node master (#1612) #1767

merged 1 commit into from
May 27, 2020

Conversation

blacksoul000
Copy link

  • corrected wrong indexing in NavfnPlanner::smoothApproachToGoal function

  • resolved uncrustify errors

  • corrected the condition inside NavfnPlanner::smoothApproachToGoal to replace last pose of computed path

Co-authored-by: chikmagalore.thilak chikmagalore.thilak@bshg.com


Basic Info

Info Please fill out this column
Ticket(s) this addresses (add tickets here #1)
Primary OS tested on (Ubuntu, MacOS, Windows)
Robotic platform tested on (Steve's Robot, gazebo simulation of Tally, hardware turtlebot)

Description of contribution in a few bullet points

Description of documentation updates required from your changes


Future work that may be required in bullet points

* corrected wrong indexing in NavfnPlanner::smoothApproachToGoal function

* resolved uncrustify errors

* corrected the condition inside NavfnPlanner::smoothApproachToGoal to replace last pose of computed path

Co-authored-by: chikmagalore.thilak <chikmagalore.thilak@bshg.com>
@SteveMacenski SteveMacenski linked an issue May 26, 2020 that may be closed by this pull request
@SteveMacenski SteveMacenski reopened this May 26, 2020
@SteveMacenski
Copy link
Member

Retriggering ROS2 CI farm. There'sa couple of test failures I want to check on.

@SteveMacenski
Copy link
Member

This PR is causing a number of failures in the build farm that aren't usual

@SteveMacenski SteveMacenski reopened this May 26, 2020
@SteveMacenski SteveMacenski merged commit 8765a25 into ros-navigation:eloquent-devel May 27, 2020
@SteveMacenski
Copy link
Member

A new run seems to have fixed it, merged

@blacksoul000 blacksoul000 deleted the eloquent-devel branch May 28, 2020 06:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Segfault in planner server on Eloquent
3 participants