Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added RPP use_cancel_deceleration parameter #4441

Merged
merged 2 commits into from
Jun 18, 2024
Merged

Added RPP use_cancel_deceleration parameter #4441

merged 2 commits into from
Jun 18, 2024

Conversation

JatinPatil2003
Copy link
Contributor

@JatinPatil2003 JatinPatil2003 commented Jun 16, 2024 •
edited
Loading

Basic Info

Info Please fill out this column
Ticket(s) this addresses (add tickets here #4238 )
Primary OS tested on (Ubuntu, MacOS, Windows)
Robotic platform tested on (Steve's Robot, gazebo simulation of Tally, hardware turtlebot)
Does this PR contain AI generated software? (No; Yes and it is marked inline in the code)

Description of contribution in a few bullet points

Future work that may be required in bullet points

For Maintainers:

  • Check that any new parameters added are updated in docs.nav2.org
  • Check that any significant change is added to the migration guide
  • Check that any new features OR changes to existing behaviors are reflected in the tuning guide
  • Check that any new functions have Doxygen added
  • Check that any new features have test coverage
  • Check that any new plugins is added to the plugins page
  • If BT Node, Additionally: add to BT's XML index of nodes for groot, BT package's readme table, and BT library lists

@JatinPatil2003
Added RPP use_cancel_deceleration parameter
6a4a4d5 
Signed-off-by: Jatin Patil <jatinpatil2003@gmail.com>
@JatinPatil2003
Fixed Linting code style
f96ec84 
Signed-off-by: Jatin Patil <jatinpatil2003@gmail.com>
padhupradheep
padhupradheep approved these changes Jun 18, 2024
View reviewed changes
Copy link
Member

@padhupradheep padhupradheep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Tested it as well!

Great job @JatinPatil2003 Thanks for the contribution

@padhupradheep
Copy link
Member

@JatinPatil2003 Could you please also give in a PR for the documentation? Then we can get this inn..

Thanks!

@JatinPatil2003 JatinPatil2003 mentioned this pull request Jun 18, 2024
Merged
@JatinPatil2003
Copy link
Contributor Author

I have opened a PR for documentation ros-navigation/docs.nav2.org/pull/567

@SteveMacenski SteveMacenski merged commit 8f795a2 into ros-navigation:main Jun 18, 2024
9 of 10 checks passed
@SteveMacenski
Copy link
Member

SteveMacenski commented Jun 18, 2024 •
edited
Loading

Thanks @JatinPatil2003 and @padhupradheep - great contributions!

@padhupradheep
Copy link
Member

was about to press merge @SteveMacenski :-D

MarcM0 pushed a commit to MarcM0/navigation2 that referenced this pull request Jul 4, 2024
@JatinPatil2003 @MarcM0
Added RPP use_cancel_deceleration parameter (ros-navigation#4441)
da75ff3 
* Added RPP use_cancel_deceleration parameter

Signed-off-by: Jatin Patil <jatinpatil2003@gmail.com>

* Fixed Linting code style

Signed-off-by: Jatin Patil <jatinpatil2003@gmail.com>

---------

Signed-off-by: Jatin Patil <jatinpatil2003@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SteveMacenski SteveMacenski SteveMacenski approved these changes

@padhupradheep padhupradheep padhupradheep approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@JatinPatil2003 @padhupradheep @SteveMacenski