Re-enable costmap tests (footprint and inflation tests) #805
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crdelsey
approved these changes
Jun 5, 2019
nav2_costmap_2d/src/layer.cpp
Outdated
| @@ -84,8 +84,8 @@ void | |||
| Layer::undeclareAllParameters() | |||
| { | |||
| std::for_each(begin(local_params_), end(local_params_), [this](const std::string & param_name) { | |||
There was a problem hiding this comment.
std::for_each makes no sense here. This should just be a simple for loop.
Suggested change
| std::for_each(begin(local_params_), end(local_params_), [this](const std::string & param_name) { | |
| for(auto & param_name : local_params_) { | |
| node_->undeclare_parameter(getFullName(param_name)); | |
| } |
PS: don't just commit the suggestion. I was only able to get the suggestion mechanism to replace the first line, but you need to replace the whole for loop
mjeronimo
added
the
nav2_lifecycle
mjeronimo
approved these changes
Jun 5, 2019
mjeronimo
pushed a commit
that referenced
this pull request
Jun 6, 2019
* re-enabling obstacle, inflation, and footprint tests * remove static tests, redesign footprint_tests without Costmap2DROS * passing linters and uncrustify * replace for_each with for loop
crdelsey
pushed a commit
that referenced
this pull request
Jun 10, 2019
* re-enabling obstacle, inflation, and footprint tests * remove static tests, redesign footprint_tests without Costmap2DROS * passing linters and uncrustify * replace for_each with for loop
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basic Info
Description of contribution in a few bullet points
Future work that may be required in bullet points
costmap_tester.cpptest is still disabled since there was a dependency on rosbag. I believe rosbag is now supported in ros2, so we can look into re-enabling this test