Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Advertize and subscribe with custom qos #288

Merged
merged 6 commits into from
Oct 9, 2023
Merged

Advertize and subscribe with custom qos #288

merged 6 commits into from
Oct 9, 2023

Conversation

ahcorde
Copy link
Collaborator

@ahcorde ahcorde commented Oct 3, 2023

Advertize with custom qos, this should allow to use best_effort

FYI @adityapande-1995

@ahcorde
Advertize with custom qos
6c1e828 
Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
@ahcorde ahcorde self-assigned this Oct 3, 2023
@ahcorde
Subscriber select qos
eb15afe 
Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
@ahcorde ahcorde changed the title Advertize with custom qos Advertize and subscribe with custom qos Oct 3, 2023
@ahcorde
make linters happy
b944d25 
Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
adityapande-1995
adityapande-1995 reviewed Oct 5, 2023
View reviewed changes
Copy link
Contributor

@adityapande-1995 adityapande-1995 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, can we add a small test for this ?

image_transport/include/image_transport/image_transport.hpp Show resolved Hide resolved
image_transport/include/image_transport/image_transport.hpp Show resolved Hide resolved
@ahcorde
Added feedback
b2d514b 
Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
adityapande-1995
adityapande-1995 approved these changes Oct 6, 2023
View reviewed changes
Copy link
Contributor

@adityapande-1995 adityapande-1995 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good with green CI and uncrustify/linting errors resolved.

@ahcorde
make linters happy
4d46f8f 
Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
@ahcorde
Copy link
Collaborator Author

ahcorde commented Oct 9, 2023

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

@ahcorde
fix windows
a46fd70 
Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
@ahcorde
Copy link
Collaborator Author

ahcorde commented Oct 9, 2023

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

@ahcorde ahcorde merged commit f9ac45d into rolling Oct 9, 2023
2 checks passed
@ahcorde ahcorde deleted the ahcorde/rolling/advertise_custom_qos branch October 9, 2023 15:00
@ahcorde ahcorde mentioned this pull request Oct 10, 2023
Merged
@ijnek ijnek mentioned this pull request Nov 7, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adityapande-1995 adityapande-1995 adityapande-1995 approved these changes

Assignees

@ahcorde ahcorde

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ahcorde @adityapande-1995